Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum required HPX version to 1.8.0 #6132

Merged
merged 1 commit into from
May 15, 2023

Conversation

msimberg
Copy link
Contributor

This should really already have been part of #5628.

Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to ask you to update the documentation and just realized there is no such section... We only mentions compilers/toolchains in https://kokkos.github.io/kokkos-core-wiki/requirements.html, nothing about third party libraries

Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to update the CI actually

@dalg24
Copy link
Member

dalg24 commented May 15, 2023

Probably need to update the CI actually

CI that actually passes.
HPX bizarrely reports

-- HPX version: 1.8.0

Oh well.
Is that a known behavior?

@cz4rs
Copy link
Contributor

cz4rs commented May 15, 2023

Probably need to update the CI actually

It's 1.8.0 on develop:

@dalg24
Copy link
Member

dalg24 commented May 15, 2023

Duh... Thank you Cezary and sorry about the noise

@dalg24 dalg24 merged commit 336473d into kokkos:develop May 15, 2023
27 of 28 checks passed
@msimberg msimberg deleted the hpx-version-requirement-1.8.0 branch May 15, 2023 13:34
@nmm0 nmm0 mentioned this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants