-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement HPX::in_parallel
#6143
Conversation
fc570a2
to
a2f3276
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. It seems we could extend the tests added to all other backends (except for Serial) but I'm fine with doing that in another pull request.
Do you know what happened on |
I do not but it looks like the clang-format test passed so it is probably ok. |
Any further comments on this? |
No. Looks good. Thank you Mikael. |
* Implement HPX::in_parallel * Don't use gtest macros in parallel regions in HPX in_parallel test
Fixes #5744. This implements the weaker form of
in_parallel
from https://kokkos.github.io/kokkos-core-wiki/API/core/execution_spaces.html?highlight=in_parallel#functionality:i.e. this does not use the
ExecutionSpace
argument toin_parallel
. I can strengthen this if useful in the future.I couldn't find any existing tests (except for
kokkos/core/unit_test/incremental/Test01_execspace.hpp
Lines 65 to 66 in 62d2b6c