Drop Kokkos_ENABLE_PROFILING_LOAD_PRINT configuration option
#6150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
approved these changes
May 19, 2023
ajpowelsnl
approved these changes
May 22, 2023
Thanks for the nudge, @Rombur : kokkos/kokkos-core-wiki#384 |
crtrott
approved these changes
May 22, 2023
|
Failure is unrelated (machine issue on one of the CUDA build) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kokkos_ENABLE_PROFILING_LOAD_PRINTis exclusively used to control whether we print a debug statement or not when initializing kokkos-tools.It was introduced in #823 because the print statement was aggravating. I doubt anyone has been missing it too much and actually enables it If we really think it is useful, I would suggest we pursue instead a runtime option on the tools side rather than a configuration time one.
I am proposing removal without going through deprecation.
Note to our Spack experts @crtrott and @janciesko that you should probably go ahead and remove that option
https://github.com/spack/spack/blob/e9e5beee1f066d1ac211740d1d0dbda6154b6e1e/var/spack/repos/builtin/packages/kokkos/package.py#L88
And while you are at it maybe remove
qthread...