Add Kokkos::all_libs alias target for compatibility with TriBITS/Trilinos
#6157
Conversation
@dalg24, you need both an ALIAS target and an exported IMPORTED target (the former is for users that pull in Kokkos with |
I don't understand. The configured file |
|
I can confirm that both |
There was a problem hiding this comment.
I looked over this too fast. This adds the Kokkos::all_libs target to both the current CMake project and the KokkosConfig.cmake file. But note this only addresses part of PR #6138. The other part is setting missing vars like Kokkos_ENABLE_CUDA_RELOCATABLE_DEVICE_CODE in the KokkosConfig.cmake file (see #6138 (comment)).
This part has been (mostly) addressed by #6142 |
| # CMake Error at <prefix>/lib/cmake/Kokkos/KokkosConfigCommon.cmake:10 (ADD_LIBRARY): | ||
| # ADD_LIBRARY cannot create ALIAS target "Kokkos::all_libs" because target | ||
| # "Kokkos::kokkos" is imported but not globally visible. | ||
| IF(CMAKE_VERSION VERSION_LESS "3.18") |
There was a problem hiding this comment.
How did I determine the cmake version?
When I submitted the original version, I had tested with my local setup that has v3.25.
I was able to reproduce the CI failures with cmake-3.16 (in the CUDA RDC build that does Kokkos_INSTALL_TESTING).
After reading https://discourse.cmake.org/t/alias-and-not-globally-visible-targets/6305 I tried 3.23.5 and it did not yield an error. Then I arbitrarily picked 3.18.0 which also worked followed by 3.17.0 that did not.
I expect this entry from the cmake 3.18 changelog is what resolved the issue.
- The add_library() and add_executable() commands learned to create Alias Targets referencing non-GLOBAL Imported Targets.
…ilinos (kokkos#6157) * Add Kokkos::all_libs alias target for compatibility with Trilinos * Add comments and fixup for cmake version less than 3.18
Proposed alternative to #6138
@bartlettroscoe is there a good reason
Kokkos::all_libscannot be an alias target?