OpenMPTarget: Changes for OpenMPTarget backend with nvhpc compiler. #6171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
dalg24
reviewed
May 31, 2023
Comment on lines
19
to
20
| // FIXME_OPENMPTARGET_NVHPC: NVHPC compiler does not support memory-order-clause in the flush construct in OpenMP. | ||
| #if _OPENMP > 201800 && !defined(_NVCOMPILER) |
There was a problem hiding this comment.
This needs a pull request on the desul-side.
There was a problem hiding this comment.
Thanks. I put in a PR in desul for the same desul/desul#107 .
There was a problem hiding this comment.
The PR was merged so you are allowed to cherry-pick into Kokkos here
dalg24
approved these changes
Jun 6, 2023
crtrott
approved these changes
Jun 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds changes to compile an app with the OpenMPTarget backend using nvhpc compiler and a Makefile based build system.