Left align demangled stacktrace output.

[vbrunini]

Closes #6190.

[dalg24]

From the clang-format check on Jenkins CI

diff --git a/core/src/impl/Kokkos_Stacktrace.cpp b/core/src/impl/Kokkos_Stacktrace.cpp
index 6ce8d77a4..577e4cfb1 100644
--- a/core/src/impl/Kokkos_Stacktrace.cpp
+++ b/core/src/impl/Kokkos_Stacktrace.cpp
@@ -170,9 +170,10 @@ main_column_info find_main_column(const std::vector<std::string>& traceback) {
   return main_column_info{found_main, main_col};
 }
 
-void demangle_and_print_traceback_entry(
-    std::ostream& out, const std::string& traceback_entry,
-    const bool found_main, const size_t main_col) {
+void demangle_and_print_traceback_entry(std::ostream& out,
+                                        const std::string& traceback_entry,
+                                        const bool found_main,
+                                        const size_t main_col) {
   std::vector<std::string> tokens;
   size_t cur_col = 0;
   for_each_token(traceback_entry, [&](const std::string& s, bool last) {

[fnrizzi]

can you please post a screenshot of what the output looks like after this PR vs what was before ?
It would help having that part of the PR, and i know there is one in the issue but would like to see the actual output of this PR

[vbrunini]

Before:

demangled test_f1:                                                                                                          Kokkos::Impl::save_stacktrace()       [0x494bb3]
                                                                                                 Test::stacktrace_test_f1(std::ostream&)       [0x43cf69]
                                                                                                       Test::test_stacktrace(bool, bool)       [0x438463]
                                                              Test::defaultdevicetype_DeathTest_stacktrace_generic_term_Test::TestBody()       [0x43a11c]
void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)       [0x472aad]
                                                                                                                                               [0x4649ca]
                                                                                                                                               [0x464e1d]
                                                                                                                                               [0x465631]
                                                                                          testing::internal::UnitTestImpl::RunAllTests()       [0x466d47]
                                                                                                                testing::UnitTest::Run()       [0x46507b]
                                                                                                                                    main       [0x4373f2]
                                                                                                                       __libc_start_main [0x7f3ece93a555]
                                                                                                                                               [0x438359]

After:

demangled test_f1:
Kokkos::Impl::save_stacktrace() [0x495713]
Test::stacktrace_test_f1(std::ostream&) [0x43dac9]
Test::test_stacktrace(bool, bool) [0x438543]
void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) [0x47360d]
 [0x46552a]
 [0x46597d]
 [0x466191]
testing::internal::UnitTestImpl::RunAllTests() [0x4678a7]
testing::UnitTest::Run() [0x465bdb]
main [0x4374a2]
__libc_start_main [0x7f9d87f9c555]
 [0x438409]

[fnrizzi]

thanks @vbrunini
I think reading left-to-right makes sense, but IMO those addresses somehow get in the way.
What about this:

maybe more people will vote on this today at the meeting

[crtrott]

Regarding the proposal for address alignment: is the address a separate string right now? It looks to me like its just part of the entire name?

[fnrizzi]

Regarding the proposal for address alignment: is the address a separate string right now? It looks to me like its just part of the entire name?

i have not checked that, but seems so. I was just proposing what looked "nice" to my eye...

[masterleinad]

We agreed on having the addresses first, then line numbers, and everything left-aligned.

[vbrunini]

Now looks like:

demangled test_f1:
 [0x495713] Kokkos::Impl::save_stacktrace()
 [0x43dac9] Test::stacktrace_test_f1(std::ostream&)
 [0x438543] Test::test_stacktrace(bool, bool)
 [0x47360d] void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
 [0x46552a] 
 [0x46597d] 
 [0x466191] 
 [0x4678a7] testing::internal::UnitTestImpl::RunAllTests()
 [0x465bdb] testing::UnitTest::Run()
 [0x4374a2] main
 [0x7f16e9f60555] __libc_start_main
 [0x438409] 

[cz4rs]

We can probably simplify even further and not worry about an extra space in the last line:

Suggested change

	out << s;
	}
	if (!last) {
	out << " ";
	out << s << " " << demangle(s);

This would get rid of bool last parameter and the second loop.

[fnrizzi]

CI seems unrelated

[dalg24]

Ignored HIP timeouts