Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team-level std algos: part 7 #6211

Merged
merged 9 commits into from
Sep 7, 2023
Merged

Team-level std algos: part 7 #6211

merged 9 commits into from
Sep 7, 2023

Conversation

fnrizzi
Copy link
Contributor

@fnrizzi fnrizzi commented Jun 12, 2023

Co-authored-by: Cezary Skrzyński
Co-authored-by: Jakub Strzebonski

Content

Team-level implementation and tests for:

  • Kokkos_Move.hpp
  • Kokkos_MoveBackward.hpp
  • Kokkos_ShiftLeft.hpp
  • Kokkos_ShiftRight.hpp

Technical comments

  • the change class -> typename and the enable if defaulted in the template parameters comes from this request

  • the code duplication is intentional and agreed upon after the long discussion in here

  • tests are run for both contiguous views and strided views

Other comments

Possible conflicts

Implementation-wise, this has not conflict with other team-level PRs so it could be merged independently.
However, a trivial conflict in the CMakeLists inside the unit test occurs if another of the team-level PRs is merged before this because each team-level PR adds test using a specific "label". Resolving this is trivial.

Associated wiki PRs

  • Kokkos_Move.hpp, Kokkos_MoveBackward.hpp: see wiki PR 366
  • Kokkos_ShiftLeft.hpp, Kokkos_ShiftRight.hpp: see wiki PR 366

IMPORTANT: wiki PRs are not complete yet but 99% there

The issue tracking all wiki PRs is here

@fnrizzi fnrizzi marked this pull request as draft June 12, 2023 14:16
@fnrizzi fnrizzi changed the title eam-level std algos: part 7 of N eam-level std algos: part 7/9 Jun 12, 2023
@PhilMiller PhilMiller changed the title eam-level std algos: part 7/9 Team-level std algos: part 7/9 Jun 12, 2023
@fnrizzi fnrizzi changed the title Team-level std algos: part 7/9 Team-level std algos: part 7 Jul 4, 2023
Co-authored-by: Cezary Skrzyński
Co-authored-by: Jakub Strzebonski
@fnrizzi fnrizzi marked this pull request as ready for review July 6, 2023 06:16
@fnrizzi fnrizzi marked this pull request as draft July 19, 2023 06:31
@fnrizzi fnrizzi marked this pull request as ready for review August 1, 2023 08:26
@fnrizzi
Copy link
Contributor Author

fnrizzi commented Sep 6, 2023

CI failure from GCC 8.4 unrelated:

The following tests FAILED:
	 37 - Kokkos_PerformanceTest_Benchmark (Timeout)
Errors while running CTest

@fnrizzi
Copy link
Contributor Author

fnrizzi commented Sep 7, 2023

unrelated Openmptarget failure:

The following tests FAILED:
	  4 - Kokkos_CoreUnitTest_OpenMPTarget (Failed)

and hpx

The following tests FAILED:
	  4 - Kokkos_CoreUnitTest_HPX (Timeout)

@crtrott crtrott merged commit fc213ea into kokkos:develop Sep 7, 2023
26 of 28 checks passed
@masterleinad masterleinad mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants