Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

team-level std algos: part 8 #6212

Merged
merged 15 commits into from
Sep 13, 2023
Merged

team-level std algos: part 8 #6212

merged 15 commits into from
Sep 13, 2023

Conversation

fnrizzi
Copy link
Contributor

@fnrizzi fnrizzi commented Jun 12, 2023

Co-authored-by: Cezary Skrzyński
Co-authored-by: Jakub Strzebonski

Content

Team-level implementation and tests for:

  • Kokkos_Copy.hpp
  • Kokkos_CopyN.hpp
  • Kokkos_CopyBackward.hpp
  • Kokkos_CopyIf.hpp
  • Kokkos_UniqueCopy.hpp
  • Kokkos_Remove.hpp
  • Kokkos_RemoveIf.hpp
  • Kokkos_RemoveCopy.hpp
  • Kokkos_RemoveCopyIf.hpp

Technical comments

  • this PR is not split any further because of the following dependencies:

    • Kokkos_UniqueCopy.hpp: needs copy
    • Kokkos_Remove.hpp: needs copy_if
    • Kokkos_RemoveIf.hpp: needs copy_if and count_if
    • Kokkos_RemoveCopy.hpp: needs copyif
    • Kokkos_RemoveCopyIf.hpp: needs copyif
  • the change class -> typename and the enable if defaulted in the template parameters comes from this request

  • the code duplication is intentional and agreed upon after the long discussion in here

  • tests are run for both contiguous views and strided views

Other comments

Possible conflicts

Implementation-wise, this has not conflict with other team-level PRs so it could be merged independently.
However, a trivial conflict in the CMakeLists inside the unit test occurs if another of the team-level PRs is merged before this because each team-level PR adds test using a specific "label". Resolving this is trivial.

Associated wiki PRs

  • Kokkos_Copy.hpp, Kokkos_CopyIf.hpp, Kokkos_CopyN.hpp, Kokkos_CopyBackward.hpp: see wiki PR
  • Kokkos_UniqueCopy.hpp, Kokkos_Remove.hpp, Kokkos_RemoveIf.hpp, Kokkos_RemoveCopy.hpp: see wiki PR
  • Kokkos_RemoveCopyIf.hpp: see wiki PR

IMPORTANT: wiki PRs are not complete yet but 99% there

The issue tracking all wiki PRs is here

Co-authored-by: Cezary Skrzyński
Co-authored-by: Jakub Strzebonski
@fnrizzi fnrizzi marked this pull request as draft June 12, 2023 14:32
@fnrizzi fnrizzi changed the title team-level std algos: part 8 of N team-level std algos: part 8/9 Jun 12, 2023
@fnrizzi fnrizzi changed the title team-level std algos: part 8/9 team-level std algos: part 8 Jul 4, 2023
@fnrizzi fnrizzi marked this pull request as ready for review August 3, 2023 09:11
@crtrott
Copy link
Member

crtrott commented Sep 7, 2023

Retest this please

@crtrott crtrott merged commit 6494d96 into kokkos:develop Sep 13, 2023
28 checks passed
@masterleinad masterleinad mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants