make constraints on Kokkos::sort more visible/clear
#6234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnrizzi
changed the title
fnrizzi
changed the title
fnrizzi
changed the title
Kokkos::sort more visible/clear
|
Please remind me why we care about sorting |
I actually had no idea, and found out that it was supporting that when doing this work ... if i had to guess, it comes from lammps or maybe maybe something else particle-based. Even if lammps does not call kokkos sort directly |
dalg24
reviewed
Jun 22, 2023
dalg24
reviewed
Jun 22, 2023
dalg24
approved these changes
Jun 22, 2023
|
@masterleinad I made all changes you requested |
masterleinad
approved these changes
Jun 22, 2023
PhilMiller
reviewed
Jun 24, 2023
| @@ -219,6 +258,10 @@ std::enable_if_t<Kokkos::is_execution_space<ExecutionSpace>::value> sort( | |||
|
|
|||
| template <class ViewType> | |||
| void sort(ViewType view, size_t const begin, size_t const end) { | |||
| // same constraints as the overload above which this gets dispatched to | |||
| static_assert(ViewType::rank == 1, | |||
There was a problem hiding this comment.
These all need to call the member function rank() if DynRankView if rank 1 is to be supported.
There was a problem hiding this comment.
this won't work for binsort beause of this: https://github.com/kokkos/kokkos/blob/develop/algorithms/src/sorting/impl/Kokkos_CopyOpsForBinSortImpl.hpp
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the constraints on the sort functions were a bit hidden: for example some overloads accept a dynamic view, while some others don't. This PR clarifies directly at the API level what the constraints are on the current sort API, thus making it clearly visible right away (aka one does not have to dig a few layers to figure out what is allowed)
Minor: clang format is turned off so that the the public API is more readable (IMMO)