Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows symlink configure issue #6241

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Fix windows symlink configure issue #6241

merged 2 commits into from
Jun 27, 2023

Conversation

crtrott
Copy link
Member

@crtrott crtrott commented Jun 26, 2023

Symlink creation requires elevated privileges on windows.

@crtrott
Fix windows symlink configure issue
c2cc337 
symlink creation requires elevated privileges
dalg24
dalg24 reviewed Jun 26, 2023
View reviewed changes
cmake/kokkos_install.cmake Outdated Show resolved Hide resolved
dalg24
dalg24 reviewed Jun 26, 2023
View reviewed changes
cmake/kokkos_install.cmake Outdated Show resolved Hide resolved
@crtrott @dalg24
Update cmake/kokkos_install.cmake
e94fc8c 
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
@masterleinad masterleinad mentioned this pull request Jun 27, 2023
Merged
@masterleinad
Copy link
Contributor

Only CUDA-11.7-NVHPC is failing with

NVC++-S-0000-Internal compiler error. extractor: bad opc       0  (/var/jenkins/workspace/Kokkos/algorithms/unit_tests/TestStdAlgorithmsMoveBackward.cpp: 216)
NVC++-S-0000-Internal compiler error. extractor: bad opc       0  (/var/jenkins/workspace/Kokkos/algorithms/unit_tests/TestStdAlgorithmsMoveBackward.cpp: 216)
NVC++-S-0000-Internal compiler error. extractor: bad opc       0  (/var/jenkins/workspace/Kokkos/algorithms/unit_tests/TestStdAlgorithmsMoveBackward.cpp: 216)
NVC++-S-0000-Internal compiler error. extractor: bad opc       0  (/var/jenkins/workspace/Kokkos/algorithms/unit_tests/TestStdAlgorithmsMoveBackward.cpp: 216)
NVC++-S-0000-Internal compiler error. extractor: bad opc       0  (/var/jenkins/workspace/Kokkos/algorithms/unit_tests/TestStdAlgorithmsMoveBackward.cpp: 216)
NVC++-S-0000-Internal compiler error. extractor: bad opc       0  (/var/jenkins/workspace/Kokkos/algorithms/unit_tests/TestStdAlgorithmsMoveBackward.cpp: 216)
NVC++-S-0000-Internal compiler error. extractor: bad opc       0  (/var/jenkins/workspace/Kokkos/algorithms/unit_tests/TestStdAlgorithmsMoveBackward.cpp: 216)
NVC++-S-0000-Internal compiler error. extractor: bad opc       0  (/var/jenkins/workspace/Kokkos/algorithms/unit_tests/TestStdAlgorithmsMoveBackward.cpp: 216)
NVC++/x86-64 Linux 22.9-0: compilation completed with severe errors
make[2]: *** [algorithms/unit_tests/CMakeFiles/Kokkos_AlgorithmsUnitTest_StdSet_C.dir/build.make:272: algorithms/unit_tests/CMakeFiles/Kokkos_AlgorithmsUnitTest_StdSet_C.dir/TestStdAlgorithmsMoveBackward.cpp.o] Error 2
make[2]: *** Waiting for unfinished jobs....

which looks unrelated.

@crtrott crtrott merged commit 2cd6bbc into kokkos:develop Jun 27, 2023
27 of 28 checks passed
@crtrott crtrott deleted the fix-windows-symlink branch June 27, 2023 19:06
crtrott added a commit to ndellingwood/kokkos that referenced this pull request Jun 27, 2023
@crtrott @dalg24
Fix windows symlink configure issue (kokkos#6241)
3e85bd9 
* Fix windows symlink configure issue

symlink creation requires elevated privileges

* Update cmake/kokkos_install.cmake

Co-authored-by: Damien L-G <dalg24+github@gmail.com>

---------

Co-authored-by: Damien L-G <dalg24+github@gmail.com>
@ndellingwood ndellingwood mentioned this pull request Jun 28, 2023
Merged
@fnrizzi fnrizzi mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@masterleinad masterleinad masterleinad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crtrott @masterleinad @dalg24