-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SYCL: Use in-order queues in InterOp tests #6246
SYCL: Use in-order queues in InterOp tests #6246
Conversation
af69f4f
to
4830ea6
Compare
Retest this please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that not be a precondition on SYCL constructor that accept a queue?
By that it means, why aren't we checking that the user-provided queue has the "in order" property?
Good idea. 55a5899 |
We could make the things which are protected by in-order macro protected by a runtime check instead. Thus it would work either way for interop purposes. We could also wait with that until someone asks and until then we unconditionally check. |
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
SYCL tests do not pass (precondition is in-order queue violations) |
64bb0bb
to
89eeef1
Compare
Sorry about that. Fixed! |
For the
which looks unrelated. |
Please make sure you mention the enforcing the precondition in the changelog |
Follow-up to #6189. Since we might be relying on
sycl::queues
to be in-order now, we should also use in-order queues in the interoperability tests to be on the safe side.