Ensure that Kokkos::complex only gets instantiated for cv-unqualified floating-point types
#6251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnrizzi
approved these changes
Jul 3, 2023
nliber
approved these changes
Jul 5, 2023
ldh4
approved these changes
Jul 5, 2023
|
Do you guys want a comment about half/bhalf type support? |
e10harvey
approved these changes
Jul 5, 2023
| @@ -44,6 +44,11 @@ class | |||
| alignas(2 * sizeof(RealType)) | |||
| #endif | |||
| complex { | |||
| static_assert(std::is_floating_point_v<RealType> && | |||
There was a problem hiding this comment.
Shall we merge this and then add a follow on PR with:
Suggested change
| static_assert(std::is_floating_point_v<RealType> && | |
| static_assert((std::is_floating_point_v<RealType> && | |
| std::is_same_v<RealType, std::remove_cv_t<RealType>) || | |
| kokkos_type_is_half<RealType>::value) |
There was a problem hiding this comment.
I do not see any usage of Kokkos::complex with half_t or bhalf_t in Trilinos:
https://github.com/search?q=repo%3Atrilinos%2FTrilinos+Kokkos%3A%3Acomplex+half_t&type=code
There was a problem hiding this comment.
Except that
kokkos_type_is_halfis not yet a thing- that including
<Kokkos_Half.hpp>is not acceptable
so we would have to explore some other mechanism to enable if we decide to add support.
|
Ignoring timeouts in OpenMPTarget build |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6069 (comment) uncovered a bug where we accidentally instantiated
Kokkos::complexfor integral types.This PR is open as a base for discussion and proposes to static assert that
complexis being instantiated for a cv-unqualified floating-point type. The current implementation would not allow for using half types.