Deprecate Kokkos::vector
#6252
Deprecate Kokkos::vector
#6252
Conversation
|
some jenkins are failing bc DKokkos_ENABLE_DEPRECATED_CODE_4 is on, so this PR triggers the expected warning. |
|
We confirmed in the meeting that we want to deprecate it. |
|
There are a couple unrelated failures (machine issues) |
| #if defined(KOKKOS_ENABLE_DEPRECATED_CODE_4) | ||
| #if defined(KOKKOS_ENABLE_DEPRECATION_WARNINGS) | ||
| namespace { | ||
| [[deprecated("Deprecated <Kokkos_Vector.hpp> header is included")]] int |
There was a problem hiding this comment.
@masterleinad why did you do this rather than KOKKOS_DEPRECATED_WITH_COMMENT?
There was a problem hiding this comment.
What I cared about is using "#error" and including "Kokkos_Macros.hpp" but not so much about using KOKKOS_DEPRECATED_WITH_COMMENT as opposed to KOKKOS_ENABLE_DEPRECATION_WARNINGS. The way now at least only declares extra symbols when they are needed for the deprecation warning.
There was a problem hiding this comment.
Good enough.
To be pedantic, there will be no symbol, that is why I used an anonymous namespace.
|
Two failures look unrelated. One is lost connection with the runner, this other one is failure to start the container. |
Deprecated in kokkos/kokkos#6252
Rational:
Kokkos::vectormight have been relevant in the past to ease the transition to Kokkos but this is really not something we want people to use any more.It is at times the source of confusion (quite different to
Kokkos::array,Kokkos::pair, orKokkos::complex).I suggest we mark it as deprecated and prepare for removal in Kokkos 5.0