make Kokkos_CXX_COMPILER_VERSION available to CMake consumers #6282
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crtrott
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
I don't see a good reason not to export KOKKOS_CXX_COMPILER_VERSION, if we export KOKKOS_CXX_COMPILER_ID too. I could see an argument for ONLY exporting Kokkos_CXX_COMPILER to enable check for using the same compiler. But in fact even checking for same compiler to be rigorous probably should check for same compiler version too.
dalg24
approved these changes
Jul 14, 2023
|
Ignoring failure to start of one of the CUDA build |
|
Make sure you add to the changelog |
Closed
|
Done, thanks for the reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be generally useful to people, but the specific need is that a new performance test in Kokkos Kernels uses
std::filesystem, and the rocm 5.2 compiler has that in a different library andexperimentalnamespace, so we need to do some different configuration based on the compiler version.