Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5635: SYCL: Add Overloads for parallel_scan with return value for TeamThreadRange #6307

Merged
merged 3 commits into from
Oct 4, 2023
Merged

#5635: SYCL: Add Overloads for parallel_scan with return value for TeamThreadRange #6307

merged 3 commits into from
Oct 4, 2023

Conversation

thearusable
Copy link
Contributor

@thearusable thearusable commented Jul 25, 2023 •
edited by cz4rs

Related to #5635 #6453

Depends on #6303 (merged)

@thearusable thearusable requested a review from fnrizzi July 25, 2023 13:05
@thearusable thearusable self-assigned this Jul 25, 2023
@masterleinad
Copy link
Contributor

Marking as draft since dependencies have not been merged.

@masterleinad masterleinad marked this pull request as draft August 9, 2023 21:15
@masterleinad masterleinad mentioned this pull request Sep 14, 2023
Closed
@cz4rs cz4rs mentioned this pull request Sep 19, 2023
Closed
fnrizzi
fnrizzi approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@fnrizzi fnrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok with me - caveat my very minor suggestion

@cz4rs cz4rs force-pushed the 5635-sycl-parallel-scan-with-value-TeamThreadRange branch from 94dc21f to bbfe639 Compare September 27, 2023 10:20
@cz4rs cz4rs marked this pull request as ready for review September 27, 2023 10:24
@cz4rs
Copy link
Contributor

cz4rs commented Sep 27, 2023

OpenMPTarget failure is unrelated.

@crtrott crtrott merged commit e04f637 into kokkos:develop Oct 4, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cz4rs cz4rs cz4rs left review comments

@masterleinad masterleinad masterleinad approved these changes

@crtrott crtrott crtrott approved these changes

@fnrizzi fnrizzi fnrizzi approved these changes

Assignees

@thearusable thearusable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thearusable @masterleinad @cz4rs @crtrott @fnrizzi