Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve execution space in HostMirror if possible #6311

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

masterleinad
Copy link
Contributor

Fixes #6310.

@masterleinad
Copy link
Contributor Author

It turns out that doing

using HostMirror = View<
      typename traits::non_const_data_type, typename traits::array_layout,
      Device<std::conditional_t<
                 SpaceAccessibility<typename traits::execution_space,
                                    typename traits::host_mirror_space::
                                        memory_space>::accessible,
                 typename traits::execution_space, DefaultHostExecutionSpace>,
             typename traits::host_mirror_space::memory_space>,
      typename traits::hooks_policy>;

isn't compatible with the DualView implementation (for SharedSpace/CudaUVMSpace) that detects the View to work on based on a full match of the device derived from HostMirror. The last commit instead only keeps the execution space if it can access HostSpace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant