Use /usr/bin/env bash in nvcc_wrapper and kokkos_launch_compiler for portability

[msimberg]

This is useful e.g. on NixOS where bash is not in /bin. As far as I know there's no downside to using /usr/bin/env bash as it should be strictly more portable, but am I missing some reason for keeping /bin/bash hardcoded in kokkos_launch_compiler and nvcc_wrapper?

[dalg24]

Can't think of any good reason not to update the shebang to use the env utility.

[msimberg]

Failures look like what is being fixed by #6354.

[cz4rs]

This is useful e.g. on NixOS where bash is not in /bin. As far as I know there's no downside to using /usr/bin/env bash as it should be strictly more portable, but am I missing some reason for keeping /bin/bash hardcoded in kokkos_launch_compiler and nvcc_wrapper?

Some distros complain about using /usr/bin/env - see Fedora's guideline (this is only a draft!) and rather lenghty discussion here. Main issue seems to be automated dependency tracking.
AFAIK there is no hard requirement to avoid it in Fedora and openSUSE shows rpmlint warning for such scripts.

[cz4rs]

Distro packages can be trivially patched, so that's still 👍 for me.
As a bonus, now all the scripts in bin directory use the same shebang.