Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code 3 support for volatile join #6385

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

crtrott
Copy link
Member

@crtrott crtrott commented Aug 24, 2023

This wasn't working in Serial and Threads anymore anyway. We just didn't test those guys.

This wasn't working in Serial and Threads anymore anyway.
We just didn't test those guys.
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to add to the changelog after it gets merged

@dalg24
Copy link
Member

dalg24 commented Aug 25, 2023

A few builds timed out. This is clearly unrelated.

@dalg24 dalg24 merged commit f85f499 into kokkos:develop Aug 25, 2023
27 of 28 checks passed
@crtrott crtrott deleted the remove_deprecated_3_volatile_join branch August 25, 2023 13:40
@crtrott crtrott mentioned this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants