Add KOKKOS_ARCH_ARM_NEON #6394
Merged
Add KOKKOS_ARCH_ARM_NEON #6394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
simd_checks_neon
branch
from
44a8fbd
to
29d4ffd
Compare
Rombur
approved these changes
Oct 6, 2023
|
What about auto detection? kokkos/cmake/kokkos_arch.cmake Lines 486 to 488 in 8181d70 |
Nevermind I see you added it. Sorry about the noise. |
dalg24
approved these changes
Oct 6, 2023
|
The CUDA 11.0 build failure is unrelated (SIMD issue being fixed in #6485). Both HIP builds timed out. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #6188. Currently, we are checking for
__ARM_NEONto enable the respective SIMD type. This is different from how we do it for all other SIMD types and this pull request makes the behavior more uniform by introducing a non-cacheKOKKOS_ARCH_ARM_NEONCMake variable and preprocessor define that works analogous toKOKKOS_ARCH_AVX512XEONand similar.Technically, this could be considered as backward-incompatible since users might have relied on the autodetection for the intrinsics.