Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate {Cuda,Hip}({cuda,hip}Stream_t, bool) #6401

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Sep 1, 2023

Whether to manage stream should not have been exposed to the user.
This was only meant as a "private" constructor to implement Experimental::partition_space().
Here I suggest we mark these constructors Cuda(cudaStream_t, bool) and Hip(hipStream_t, bool) as deprecated and replace them with constructors that take an Impl::ManageStream::{yes, no} enumerator instead of the boolean argument.

Whether to manage the stream or not should never have been exposed to
the user.
@dalg24
Copy link
Member Author

dalg24 commented Sep 1, 2023

Conflicts with #6361

@dalg24
Copy link
Member Author

dalg24 commented Sep 2, 2023

OpenMPTarget failure is clearly unrelated

4: [ RUN      ] openmptarget.partitioning_by_vector
4: /var/jenkins/workspace/Kokkos/core/unit_test/TestExecSpacePartitioning.hpp:100: Failure
4: Expected equality of these values:
4:   sum1
4:     Which is: 7642095
4:   sum2
4:     Which is: 0
4: [  FAILED  ] openmptarget.partitioning_by_vector (0 ms)

Everything else passed.

@dalg24 dalg24 merged commit 31c060a into kokkos:develop Sep 5, 2023
27 of 28 checks passed
@dalg24 dalg24 deleted the manage_stream_should_be_private branch September 5, 2023 12:42
@masterleinad masterleinad mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants