Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential data race in HIP parallel reduce #6429

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Potential data race in HIP parallel reduce #6429

merged 1 commit into from
Sep 13, 2023

Conversation

tcclevenger
Copy link
Contributor

Unnecessary computation creates a potential race condition in HIP. Same as the CUDA version in #6236.

@fnrizzi
Copy link
Contributor

fnrizzi commented Sep 12, 2023

retest this please

@dalg24
Copy link
Member

dalg24 commented Sep 12, 2023

Both HIP build timed out. Retest this please.

@dalg24
Copy link
Member

dalg24 commented Sep 13, 2023

Ignoring

The following tests FAILED:
	 37 - Kokkos_PerformanceTest_Benchmark (Timeout)

in the GCC build. It passed before I re-triggered.

@dalg24 dalg24 merged commit c046bdb into kokkos:develop Sep 13, 2023
27 of 28 checks passed
@tcclevenger tcclevenger deleted the hip_potential_race_condition branch September 13, 2023 14:15
@masterleinad masterleinad mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rombur Rombur Rombur approved these changes

@masterleinad masterleinad masterleinad approved these changes

@ldh4 ldh4 ldh4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tcclevenger @fnrizzi @dalg24 @Rombur @masterleinad @ldh4