Initialize m_num_scratch_locks for Cuda parallel_for TeamPolicy #6433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
added
Bug
dalg24
approved these changes
Sep 13, 2023
| // Requesting per team scratch memory for a largish number of teams, resulted | ||
| // in problems computing the correct scratch pointer due to missed | ||
| // initialization of the maximum number of scratch pad indices in the Cuda | ||
| // baackend. |
There was a problem hiding this comment.
Suggested change
| // baackend. | |
| // backend. |
There was a problem hiding this comment.
I'll fix if there are any other changes required/requested.
fnrizzi
approved these changes
Sep 13, 2023
|
@masterleinad did you identify when this bug was introduced? |
Looks like 5d93865 (#5814) where we introduced |
|
Please open an issue listing fixes that would be going into an 4.0.01 if we do a patch release and add this one. |
This was referenced Sep 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6398. Since we are missing the initialization we are running into undefined behavior and it's difficult to reliably reproduce the issue in the test suite (although it always failed in a stand-alone reproducer). Disabling other tests around it or executing them in a different order made the test pass or fail for me (without the fix).