Moving abort and assert into their own public headers #6445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnrizzi
reviewed
Sep 20, 2023
fnrizzi
approved these changes
Sep 20, 2023
nliber
force-pushed
the
abort-assert
branch
from
955f878
to
d7e5d97
Compare
masterleinad
approved these changes
Sep 20, 2023
masterleinad
requested changes
Sep 20, 2023
nliber
force-pushed
the
abort-assert
branch
from
0a7167f
to
d4594a2
Compare
masterleinad
approved these changes
Sep 21, 2023
Closed
dalg24
reviewed
Sep 25, 2023
nliber
force-pushed
the
abort-assert
branch
from
d4594a2
to
ff1e842
Compare
Kokkos_Error.hpp to Kokkos_Assert.hpp
Kokkos_Abort.cpp
Kokkos_Abort.cpp
Kokkos_Abort.hpp
Removed extraneous Kokkos_Error.hpp header Put traceback_callstack into an anonymous namespace
nliber
force-pushed
the
abort-assert
branch
from
ff1e842
to
1fdb73f
Compare
cz4rs
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5403
Kokkos::abortis now in core/src/Kokkos_Abort.hpp.KOKKOS_ASSERT,KOKKOS_EXPECTS&KOKKOS_ENSURESis now in core/src/Kokkos_Assert.hpp.The implementation of
Kokkos::Impl::host_abortis now in core/src/impl/Kokkos_Abort.cpp.