Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaning: remove iostream from headers where possible (IWYU) #6482

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

romintomasetti
Copy link
Contributor

This PR removes #include <iostream> where possible from header files.

Related to "Include What You Use" policy (IWYU).

Extracted from #6198 (see /pull/6198#discussion_r1345760198).

@dalg24-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@dalg24
Copy link
Member

dalg24 commented Oct 4, 2023

OK to test

Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that the CI passes

@romintomasetti
Copy link
Contributor Author

There are 2 failing jobs.

  1. Timeout on HPX
  2. Failure of a Cuda build with:
    [ 99%] Linking CXX executable Kokkos_AlgorithmsUnitTest_StdSet_Team_M
    
    /var/jenkins/workspace/Kokkos/install/include/Kokkos_SIMD_Common.hpp(452): error: "Kokkos::Experimental::simd<int32_t, Kokkos::Experimental::simd_abi::avx512_fixed_size<8>>" contains a vector, which is not supported in device code
    
          detected during:
    
            instantiation of "Kokkos::Experimental::simd<T, Abi> Kokkos::abs(const Kokkos::Experimental::simd<T, Abi> &) [with T=int32_t, Abi=Kokkos::Experimental::simd_abi::avx512_fixed_size<8>]" 
    
    (452): here
    It looks like this compile issue is uncorrelated to this PR.

@cz4rs
Copy link
Contributor

cz4rs commented Oct 6, 2023

There are 2 failing jobs.
(...)
It looks like this compile issue is uncorrelated to this PR.

Yep, HPX timeout is a known issue and the fix for Cuda / SIMD failure is already on its way (#6485).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants