Fix NVCC warnings #6483
Merged
Fix NVCC warnings #6483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnrizzi
reviewed
Oct 4, 2023
dalg24
reviewed
Oct 5, 2023
dalg24
reviewed
Oct 5, 2023
dalg24
approved these changes
Oct 5, 2023
fnrizzi
approved these changes
Oct 5, 2023
Closed
|
I finally got a chance to check this PR and it fixes all the warnings I was seeing, thanks @masterleinad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bunch of warnings we are currently seeing in our CI, particularly for calling
__host__functions from__host____device__functions and "missing return type".if constexpr (use_std_sort)inBinSortdidn't entirely suppress the warning, at least not for @stanmoore1.nvccallows usingbuiltin_unreachablefrom 11.3.0 on which helps with warnings of type "missing return type".stdfunctions such asstd::mininKOKKOS_FUNCTIONs.