Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implementation for cyl_bessel_i0 #6484

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

masterleinad
Copy link
Contributor

@masterleinad masterleinad commented Oct 4, 2023

Fixes #6475. The updated implementation uses CIK01 instead of CIKNB from https://people.math.sc.edu/Burkardt/f_src/special_functions/special_functions.f90 which seems more appropriate.
Also see https://en.wikipedia.org/wiki/Bessel_function#Modified_Bessel_functions for the power series used.

Copy link
Contributor

@vqd8a vqd8a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masterleinad Thanks for fixing it. LGTM.

@crtrott crtrott merged commit 1ebb3af into kokkos:develop Oct 6, 2023
27 of 28 checks passed
@masterleinad masterleinad mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants