Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYCL: Use host-pinned memory to copy reduction/scan result #6500

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

masterleinad
Copy link
Contributor

@masterleinad masterleinad commented Oct 11, 2023

For dot-type kernels, I see an improvement between 10% and 50% in runtime when using host-pinned memory with memcpy vs. device memory with sycl::queue::memcpy on Intel GPUs. This is analogous to what we are doing for Cuda and HIP.

Noticed while looking at #5334.

@masterleinad
Copy link
Contributor Author

CUDA-12.2-NVHPC and OPENACC-NVHPC-CUDA-12.2 were timing out, OPENMPTARGET-Clang failed openmptarget.partitioning_by_vector which we see regularly. Everything else, In particular the SYCL build, passes.

@masterleinad masterleinad marked this pull request as ready for review October 17, 2023 14:06
@masterleinad
Copy link
Contributor Author

Retest this please.

@masterleinad
Copy link
Contributor Author

All CI is passing.

@dalg24 dalg24 merged commit 0975671 into kokkos:develop Oct 26, 2023
28 checks passed
@masterleinad masterleinad deleted the sycl_reduce_host_memory_copy branch October 26, 2023 15:26
@masterleinad masterleinad mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants