-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SYCL: Use host-pinned memory to copy reduction/scan result #6500
Merged
dalg24
merged 5 commits into
kokkos:develop
from
masterleinad:sycl_reduce_host_memory_copy
Oct 26, 2023
Merged
SYCL: Use host-pinned memory to copy reduction/scan result #6500
dalg24
merged 5 commits into
kokkos:develop
from
masterleinad:sycl_reduce_host_memory_copy
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
sycl_reduce_host_memory_copy
branch
from
October 17, 2023 02:26
fb18a1c
to
a99013e
Compare
|
Rombur
approved these changes
Oct 18, 2023
dalg24
reviewed
Oct 23, 2023
dalg24
reviewed
Oct 24, 2023
dalg24
approved these changes
Oct 24, 2023
Retest this please. |
All CI is passing. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For dot-type kernels, I see an improvement between 10% and 50% in runtime when using host-pinned memory with
memcpy
vs. device memory withsycl::queue::memcpy
on Intel GPUs. This is analogous to what we are doing forCuda
andHIP
.Noticed while looking at #5334.