Remove all DEPRECATED_CODE_3 option and all code that was guarded by it #6523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…: for clamp, min, max, and minmax
…: for all math functions
…: for all math constants
OpenMP::impl_thread_pool_rank() is used in UniqueToken::acquire()
dalg24
commented
Oct 18, 2023
Comment on lines
-169
to
-170
| // FIXME_OPENMP Can we remove this when removing partition_master? It's only | ||
| // used in one partition_master test |
There was a problem hiding this comment.
Used in UniqueToken::acquire() as stated in commit message
|
…mental:: for all math functions
Rombur
approved these changes
Oct 18, 2023
rgayatri23
approved these changes
Oct 18, 2023
|
Did we check in with customers who were relying on some of these features? |
No. |
masterleinad
approved these changes
Oct 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next release will be Kokkos 4.3, about a year after version 4.0, so now is a good time to get rid of these.
This PR removes the
Kokkos_ENABLE_DEPRECATED_CODE_3option and the correspondingKOKKOS_ENABLE_DEPRECATED_CODE_3macro. All associated code is purged.Deprecating features being removed include:
InitArgumentsKOKKOS_ACTIVE_EXECUTION_MEMORY_SPACE_*macrosExperimental::{clamp, min, max, minmax}Experimental:: namespacefor all math functions and math constants{OpenMP,HPX}::partition_masterMasterLock