Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Makefile when using gnu_generate_makefile.sh and make >= 4.3 #6606

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fix Makefile when using gnu_generate_makefile.sh and make >= 4.3 #6606

merged 1 commit into from
Nov 17, 2023

Conversation

pkestene
Copy link
Contributor

Fix issue #6605

masterleinad
masterleinad approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is similar to what we are doing in Makefile.kokkos.

@dalg24
Copy link
Member

dalg24 commented Nov 16, 2023

This is similar to what we are doing in Makefile.kokkos.

Daniel is referring to #2972
Should we should use $H then instead of introducing a new variable for it?

kokkos/Makefile.kokkos

Lines 462 to 463 in 04bdcd2

# assign hash sign to variable for compat. with make 4.3
H := \#

@pkestene
Copy link
Contributor Author

pkestene commented Nov 16, 2023 •
edited

@dalg24
Sorry, I was not aware that a 'hash' variable was already defined.
I will remove definition of "HASH" use "H" instead

@crtrott crtrott merged commit 1a14531 into kokkos:develop Nov 17, 2023
25 of 27 checks passed
@masterleinad masterleinad mentioned this pull request Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rombur Rombur Rombur approved these changes

@masterleinad masterleinad masterleinad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pkestene @dalg24 @Rombur @masterleinad @crtrott