nvcc(wrapper): adding "long" and "short" versions for all flags #6615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnrizzi
reviewed
Nov 22, 2023
fnrizzi
reviewed
Nov 22, 2023
fnrizzi
changed the title
--generate-line-info arg
romintomasetti
force-pushed
the
nvcc-wrapper-missing
branch
from
d2bf043
to
dc5078b
Compare
fnrizzi
approved these changes
Nov 22, 2023
masterleinad
requested changes
Nov 22, 2023
fnrizzi
reviewed
Nov 22, 2023
romintomasetti
force-pushed
the
nvcc-wrapper-missing
branch
from
dc5078b
to
0262f74
Compare
cz4rs
approved these changes
Nov 22, 2023
|
Is there anything we can do to make the pipeline happy ? Should I rebase on the develop to fetch a fix or something? |
no, unfortunately the jenkins is still broken and needs to be fixed ! |
crtrott
approved these changes
Nov 27, 2023
|
Its a bit of a mess but I guess we just need to clean this up in a holistic manner at some point. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds "long" and "short" versions of valid
nvccflags to thenvcc_wrapperscript.