graph(HIP): adding inline keyword to fix #6623 #6624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
previously requested changes
Nov 27, 2023
There was a problem hiding this comment.
The inline specifier goes on the definition.
https://isocpp.org/wiki/faq/inline-functions#where-to-put-inline-keyword
romintomasetti
force-pushed
the
kokkos-graph-hip-fix
branch
from
9885348
to
3588c23
Compare
romintomasetti
force-pushed
the
kokkos-graph-hip-fix
branch
from
3588c23
to
f31436a
Compare
masterleinad
approved these changes
Nov 27, 2023
Rombur
approved these changes
Nov 27, 2023
masterleinad
pushed a commit
to masterleinad/kokkos
that referenced
this pull request
Nov 27, 2023
graph(HIP): adding inline keyword to fix kokkos#6623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing
inlinekeyword in the specialization ofKokkos::Impl::GraphImplforKokkos::HIP.Fixes #6623.