tools(profiling): fix typo Kokkos_Tools_Optim[i]zationGoal

[romintomasetti]

This PR accompanies kokkos/kokkos-tools/pull/221.

It fixes the typo Kokkos_Tools_OptimzationGoal to Kokkos_Tools_OptimizationGoal.

Risks

• No risk: For people fetching this change, there would be a clear compilation error if they relied on the old name. They would simply need to fix the typo on their side as well.
• Minor risk: For tools that have been compiled in the past, this might be a breaking change. However, we deem there are not so many tools out there that rely on this "optimization goal" feature. We could mitigate this risk by making the change enclosed in a "deprecated code" region.

[dalg24]

Although obviously this was a typo, this would be a breaking change.
We need to discuss whether it is acceptable/worth to proceed.

[masterleinad]

I think we should just add a deprecated alias.

[dalg24]

Tuning is still considered experimental and it is unlikely to be broadly used so I am not necessarily opposed to fix.
I supposed if we are really worried we could increment KOKKOSP_INTERFACE_VERSION.

[dalg24]

I think we should just add a deprecated alias.

An alias in C? How would that work? :)

[masterleinad]

An alias in C? How would that work? :)

Yeah, didn't pay attention that this is the C interface.

Tuning is still considered experimental and it is unlikely to be broadly used so I am not necessarily opposed to fix.

I agree.

[romintomasetti]

So, what's next then ? 😆

[dalg24]

@khuck how do you feel about that change?

[khuck]

@khuck how do you feel about that change?

It's fine with me, I don't use that symbol in APEX...

[dalg24]

Ignoring Jenkins CI