Improve handling of printf in OMPT on Intel GPUs #6652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
ompt_printf
branch
from
85ecc69
to
79164a4
Compare
|
@rgayatri23 ping |
rgayatri23
approved these changes
Dec 21, 2023
dalg24
reviewed
Dec 21, 2023
Comment on lines
+45
to
+46
| if constexpr (sizeof...(Args) == 0) | ||
| ::printf("%s", format); |
There was a problem hiding this comment.
Do we still need handle no arguments passed separately with these changes?
There was a problem hiding this comment.
Yes, this still avoids warnings (I don't exactly recall which exact compiler and compiler versions) and was part of the implementation before we made changes for OpenMPTarget, see https://github.com/kokkos/kokkos/pull/6083/files.
dalg24
approved these changes
Dec 21, 2023
|
Ignoring failures as they are due to storage issue on the test machines. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #6650 (comment).
We are currently not printing anything when using
OpenMPTargetonIntelGPUs and a non-zero number of arguments. We discussed that we rather give up on controlling the interface in this case and importprintffrom the global namespace.