Remove deprecation warning for AllocationMechanism for gcc <11.0 #6653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
In case it is useful to anyone else https://godbolt.org/z/bbenczfbE
|
Will need to cherry-pick into the patch release 4.2.01 |
masterleinad
pushed a commit
that referenced
this pull request
Dec 7, 2023
…ion_mechanism_gcc_11_0 Remove deprecation warning for AllocationMechanism for gcc <11.0
cgcgcg
added a commit
to cgcgcg/Trilinos
that referenced
this pull request
Dec 21, 2023
Propagates the change from kokkos/kokkos#6653
cgcgcg
added a commit
to cgcgcg/Trilinos
that referenced
this pull request
Dec 21, 2023
Propagates the change from kokkos/kokkos#6653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the conversation in https://kokkosteam.slack.com/archives/C5BGU5NDQ/p1701727560890859.
We see deprecation warnings for GCC versions before release 11 every time a compilation unit includes
Kokkos_HostSpace.hpp.This pull request proposes removing the deprecation attribute for
AllocationMechanismto avoid these warnings. It seems very unlikely that the enum would be used without theHostSpaceconstructor in question that still has the deprecation attribute.