Fix msvc cuda develop #6659
Merged
Fix msvc cuda develop #6659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also split math functions test differently to avoid need for bigobj
dalg24
reviewed
Dec 9, 2023
| (defined(KOKKOS_COMPILER_NVCC) && KOKKOS_COMPILER_NVCC >= 1130) | ||
| #if defined KOKKOS_COMPILER_INTEL || \ | ||
| (defined(KOKKOS_COMPILER_NVCC) && KOKKOS_COMPILER_NVCC >= 1130 && \ | ||
| !defined(KOKKOS_COMPILER_MSVC)) |
There was a problem hiding this comment.
Consider updating the comment above
| @@ -1581,6 +1585,7 @@ struct TestIsFinite { | |||
| ++e; | |||
| Kokkos::printf("failed isfinite(float)\n"); | |||
| } | |||
| #if !(defined(KOKKOS_ENABLE_CUDA) && defined(KOKKOS_COMPILER_MSVC)) | |||
There was a problem hiding this comment.
What is the deal with commenting out some of the half type tests?. Neither the commit messages nor the description refer to these changes.
There was a problem hiding this comment.
ah yeah I guess missed that in the message: some random error inside system header files ...
| @@ -394,10 +395,12 @@ DEFINE_UNARY_FUNCTION_EVAL(log2, 2); | |||
| DEFINE_UNARY_FUNCTION_EVAL(log1p, 2); | |||
| #endif | |||
|
|
|||
| #ifndef KOKKOS_MATHEMATICAL_FUNCTIONS_SKIP_1 | |||
| #ifndef KOKKOS_MATHEMATICAL_FUNCTIONS_SKIP_2 | |||
There was a problem hiding this comment.
Can you comment about what you did here (on GH). You just randomly moved tests from on exe to the other or was there some reasoning behind it?
dalg24
approved these changes
Dec 9, 2023
fnrizzi
reviewed
Dec 10, 2023
fnrizzi
approved these changes
Dec 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various small fixups for MSVC/CUDA build: