Let Profiling::ProfilingSection(std::string)
constructor be explicit and nodiscard
#6690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rational: mostly consistency
This aligns with what we did for
ScopedRegion
kokkos/core/src/Kokkos_Profiling_ScopedRegion.hpp
Lines 31 to 38 in 2ac06ce
The nodiscard attribute will warn on a common beginner error to "forget" to give the scope guard variable a name (although admittedly creating a section without calling start/stop is unlikely so that error would not occur in practice).
If we do any change at all, we might as well mark the constructor as explicit.