Don't use the compiler launcher script if the compile language is CUDA. #6704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the behavior you are seeing right now? |
|
Makes sense to me ... |
crtrott
approved these changes
Jan 10, 2024
dalg24
reviewed
Jan 11, 2024
When compiling Kokkos Kernels, the compiler launcher is used as the compiler, and the script no-ops. |
masterleinad
approved these changes
Jan 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the Kokkos CMake config file will no longer force downstream packages to use the compiler launcher if Kokkos is built with
ENABLE_COMPILE_AS_CMAKE_LANGUAGE=TRUEand CUDA is enabled.