Reenable HIP testing on AMD GPUs #6731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
Rombur
changed the title
ldh4
reviewed
Jan 22, 2024
Comment on lines
+51
to
+53
| // FIXME_HIP | ||
| GTEST_SKIP() << "skipping the test because the CI on MI100 returns: error( " | ||
| "hipErrorInvalidValue)"; |
There was a problem hiding this comment.
If it fails only for MI100, should this skip be specific for MI100 rather than always skipping (i.e. by ifdef'ing against KOKKOS_ENABLE_ARCH_GFX908 or so)?
There was a problem hiding this comment.
I don't know why it fails. It could be the architecture, the version of the driver installed, it could be related to something else in the CI. For now, I just want to get the CI back up and look at that later. We should get some MI210 soon that should help to understand the issue better,
dalg24
approved these changes
Jan 22, 2024
ldh4
approved these changes
Jan 22, 2024
masterleinad
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs reenables CI on AMD using AMD GPUs. I had to disable the memory requirement test. It passes on my machine but not on the CI.