-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable HIP testing on AMD GPUs #6731
Conversation
retest this please |
// FIXME_HIP | ||
GTEST_SKIP() << "skipping the test because the CI on MI100 returns: error( " | ||
"hipErrorInvalidValue)"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it fails only for MI100, should this skip be specific for MI100 rather than always skipping (i.e. by ifdef'ing against KOKKOS_ENABLE_ARCH_GFX908
or so)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why it fails. It could be the architecture, the version of the driver installed, it could be related to something else in the CI. For now, I just want to get the CI back up and look at that later. We should get some MI210 soon that should help to understand the issue better,
This PRs reenables CI on AMD using AMD GPUs. I had to disable the memory requirement test. It passes on my machine but not on the CI.