Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let Impl::get_gpu return a std::optional<int> #6790

Merged
merged 3 commits into from Feb 8, 2024
Merged

Let Impl::get_gpu return a std::optional<int> #6790

merged 3 commits into from Feb 8, 2024

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Feb 7, 2024

Motivation: Being able to tell when the user did not specify a device and we did not detect MPI and delegate device selection to the GPU backend.

masterleinad
masterleinad approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

dalg24
dalg24 commented Feb 8, 2024
View reviewed changes
core/src/impl/Kokkos_Core.cpp Outdated Show resolved Hide resolved
@dalg24 dalg24 merged commit 8d58aad into kokkos:develop Feb 8, 2024
1 of 2 checks passed
@dalg24 dalg24 deleted the impl_get_gpu_returns_optional branch February 8, 2024 16:38
@masterleinad masterleinad mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rombur Rombur Rombur approved these changes

@masterleinad masterleinad masterleinad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dalg24 @Rombur @masterleinad