Fix deprecation warnings with GCC for pair<T1,void> comparison operators
#6989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Andrey Prokopenko <prokopenkoav@ornl.gov>
dalg24
added
Bug
masterleinad
approved these changes
May 4, 2024
crtrott
approved these changes
May 6, 2024
|
@dalg24 most of the nightly jobs are building with deprecated code off (several Trilinos integration builds have deprecated code on but no -Werror due to noise in other packages). I'll update testing for more deprecated code == on testing coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup for #6947
GCC emits deprecation warnings in the definition of comparison operators for the deprecated specialization
Kokkos::pair<T1, void>. The fix is simple: add the[[deprecated]]attribute for all of these comparison operators.The issue was spotted in the ArborX nightlies and is also present in our nighties on ORNL Jenkins, we just didn't notice.
@ndellingwood did the SNL nighty builds not catch this issue?!!
Reproducer here does not seem to be sensitive to the GCC version.