Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TPL_LIBRARY_SUFFIXES for 32-bit build #6990

Merged
merged 3 commits into from
May 7, 2024

Conversation

masterleinad
Copy link
Contributor

@masterleinad masterleinad commented May 6, 2024

For 32-bit builds, we should search for TPL libraries in lib32 instead of lib64. This should fix the last failing GitHub CI build.

The openmp.parallel_scan_with_reducers test is failing with

 RUN      ] openmp.parallel_scan_with_reducers
/__w/kokkos/kokkos/core/unit_test/TestTeamVector.hpp:1010: Failure
Expected equality of these values:
  host_outputs(i)
    Which is: 1.0302e-12
  expected(i)
    Which is: 1.0302e-12
differ at index 103
/__w/kokkos/kokkos/core/unit_test/TestTeamVector.hpp:1010: Failure
Expected equality of these values:
  host_outputs(i)
    Which is: 1.0302e-12
  expected(i)
    Which is: 1.0302e-12
differ at index 102

and I decided to just skip since we have multiple other tests disabled for this build already (and it's not related to the build issue fixed here).

@masterleinad masterleinad marked this pull request as ready for review May 6, 2024 19:36
@masterleinad
Copy link
Contributor Author

The 32-bit build is passing.

@dalg24
Copy link
Member

dalg24 commented May 7, 2024

Ignoring unrelated runtime issues in one HIP build and one CUDA build that timed out

@dalg24 dalg24 merged commit e4cc686 into kokkos:develop May 7, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants