Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qualify std:: namespace #254

Closed
nmm0 opened this issue Apr 18, 2023 · 0 comments · Fixed by #255
Closed

qualify std:: namespace #254

nmm0 opened this issue Apr 18, 2023 · 0 comments · Fixed by #255
Assignees
@nmm0
Labels
enhancement New feature or request

Comments

@nmm0
Copy link
Contributor

nmm0 commented Apr 18, 2023

Since we are currently embedding in namespace std:: we make assumptions that standard library entities don't need to be qualified with std::. In order to move away from namespace std:: we need to change that.
@nmm0 nmm0 added the enhancement New feature or request label Apr 18, 2023
@nmm0 nmm0 self-assigned this Apr 18, 2023
nmm0 added a commit to nmm0/mdspan that referenced this issue Apr 18, 2023
@nmm0
kokkos#254: add std:: in front of standard library entities even if w…
a1c8d0b 
…e are in std.
@nmm0 nmm0 mentioned this issue Apr 18, 2023
Merged
nmm0 added a commit to nmm0/mdspan that referenced this issue Apr 18, 2023
@nmm0
kokkos#254: add tuple include
dccd95f
nmm0 added a commit to nmm0/mdspan that referenced this issue Apr 20, 2023
@nmm0
kokkos#254: remove std:: in front of size_t
0dd9d9b
nmm0 added a commit to nmm0/mdspan that referenced this issue Apr 20, 2023
@nmm0
kokkos#254: replace ::size_t with size_t
cca7311
nmm0 added a commit to nmm0/mdspan that referenced this issue Apr 20, 2023
@nmm0
kokkos#254: rever accidentally namespace change commit
9cbff58
crtrott added a commit that referenced this issue Apr 20, 2023
@crtrott
Merge pull request #255 from nmm0/254-qualify-std-namespace
edf3ba8 
#254: qualify `std` namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmm0 nmm0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#254: qualify std namespace nmm0/mdspan
1 participant
@nmm0