Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#270: fix missing qualifiers in compressed_pair #271

Merged
merged 2 commits into from
Jun 6, 2023
Merged

#270: fix missing qualifiers in compressed_pair #271

merged 2 commits into from
Jun 6, 2023

Conversation

nmm0
Copy link
Contributor

@nmm0 nmm0 commented May 25, 2023 •
edited
Loading

Closes #270

@nmm0 nmm0 requested review from dalg24 and crtrott May 25, 2023 19:04
nmm0 added a commit to nmm0/kokkos that referenced this pull request May 25, 2023
@nmm0
kokkos#6161: apply mdspan changes from kokkos/mdspan#271
6634ca9
crtrott
crtrott requested changes May 25, 2023
View reviewed changes
Copy link
Member

@crtrott crtrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets catch the C++14 not supported in make

@nmm0 nmm0 changed the title #270: missing qualifiers in compressed_pair #270: ensure only C++17 and above is specified and missing qualifiers in compressed_pair May 25, 2023
@nmm0
Copy link
Contributor Author

nmm0 commented May 25, 2023

Lets catch the C++14 not supported in make

Pushed these changes

@nmm0 nmm0 mentioned this pull request May 25, 2023
Merged
dalg24
dalg24 requested changes May 25, 2023
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we do the C++14 in the same PR?
That does not seem like a good idea
What prevents you to just qualify _MDSPAN_TRAIT(std::is_empty, _T) or whatnot

@nmm0 nmm0 requested review from dalg24 and crtrott May 25, 2023 22:08
@nmm0
Copy link
Contributor Author

nmm0 commented May 25, 2023

I made the PR C++14 compatible

@dalg24
Copy link
Member

dalg24 commented May 25, 2023

Make sure you update the title line and description

@nmm0 nmm0 changed the title #270: ensure only C++17 and above is specified and missing qualifiers in compressed_pair #270: fix missing qualifiers in compressed_pair May 25, 2023
@crtrott crtrott merged commit 1084e74 into kokkos:stable Jun 6, 2023
4 checks passed
nmm0 added a commit to nmm0/kokkos that referenced this pull request Jun 6, 2023
@nmm0
kokkos#6161: apply mdspan changes from kokkos/mdspan#271
13c2fc0
dalg24 pushed a commit to kokkos/kokkos that referenced this pull request Jun 15, 2023
@nmm0 @crtrott
snapshot mdspan namespace changes (#6162)
3163aef 
* #6161: update mdspan and fix namespaces. Also import from std namespace if using system mdspan

* #6161: fix formatting

* #6161: apply mdspan changes from kokkos/mdspan#271

* #6161: make namespace qualification consistent

* #6161: fix last inconsistent namespace qual

* #6161: fix formatting

* #6161: use old C++14-compatible traits

* #6161: copy latest mdspan stable with maybe_static_array bug fix

* #6161: don't snapshot the stdmode headers as we don't use them and it can cause only conflicts

* #6161: add -DKokkos_ENABLE_IMPL_MDSPAN=ON config to the generic github ci build, nvhpc, and two cuda ci builds

* #6161: use feature test macro instead of presence of header to avoid pulling in partial mdspan implementations

* #6161: use mdspan, layout_*, and default_accessor from std namespace if using compiler-provided mdspan

* #6161: fix formatting

* #6161: guard <version> include with c++20 or above

* #6161: disable standard mdspan if using CUDA or HIP since it may not be compatible

* #6161: format fix

* Work around CUDA 11.0 deduction failure for tuple

* Do not use mdspan from compiler by default even if header is detected

* #6161: make snapshot consistent with mdspan

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
nmm0 added a commit to nmm0/kokkos that referenced this pull request Jun 15, 2023
@nmm0
kokkos#6161: apply mdspan changes from kokkos/mdspan#271
17d2c77
nmm0 added a commit to nmm0/kokkos that referenced this pull request Jun 15, 2023
@nmm0 @crtrott
snapshot mdspan namespace changes (kokkos#6162)
08b8db2 
* kokkos#6161: update mdspan and fix namespaces. Also import from std namespace if using system mdspan

* kokkos#6161: fix formatting

* kokkos#6161: apply mdspan changes from kokkos/mdspan#271

* kokkos#6161: make namespace qualification consistent

* kokkos#6161: fix last inconsistent namespace qual

* kokkos#6161: fix formatting

* kokkos#6161: use old C++14-compatible traits

* kokkos#6161: copy latest mdspan stable with maybe_static_array bug fix

* kokkos#6161: don't snapshot the stdmode headers as we don't use them and it can cause only conflicts

* kokkos#6161: add -DKokkos_ENABLE_IMPL_MDSPAN=ON config to the generic github ci build, nvhpc, and two cuda ci builds

* kokkos#6161: use feature test macro instead of presence of header to avoid pulling in partial mdspan implementations

* kokkos#6161: use mdspan, layout_*, and default_accessor from std namespace if using compiler-provided mdspan

* kokkos#6161: fix formatting

* kokkos#6161: guard <version> include with c++20 or above

* kokkos#6161: disable standard mdspan if using CUDA or HIP since it may not be compatible

* kokkos#6161: format fix

* Work around CUDA 11.0 deduction failure for tuple

* Do not use mdspan from compiler by default even if header is detected

* kokkos#6161: make snapshot consistent with mdspan

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
cz4rs pushed a commit to cz4rs/kokkos that referenced this pull request Jun 21, 2023
@nmm0 @crtrott @cz4rs
snapshot mdspan namespace changes (kokkos#6162)
e0a23c0 
* kokkos#6161: update mdspan and fix namespaces. Also import from std namespace if using system mdspan

* kokkos#6161: fix formatting

* kokkos#6161: apply mdspan changes from kokkos/mdspan#271

* kokkos#6161: make namespace qualification consistent

* kokkos#6161: fix last inconsistent namespace qual

* kokkos#6161: fix formatting

* kokkos#6161: use old C++14-compatible traits

* kokkos#6161: copy latest mdspan stable with maybe_static_array bug fix

* kokkos#6161: don't snapshot the stdmode headers as we don't use them and it can cause only conflicts

* kokkos#6161: add -DKokkos_ENABLE_IMPL_MDSPAN=ON config to the generic github ci build, nvhpc, and two cuda ci builds

* kokkos#6161: use feature test macro instead of presence of header to avoid pulling in partial mdspan implementations

* kokkos#6161: use mdspan, layout_*, and default_accessor from std namespace if using compiler-provided mdspan

* kokkos#6161: fix formatting

* kokkos#6161: guard <version> include with c++20 or above

* kokkos#6161: disable standard mdspan if using CUDA or HIP since it may not be compatible

* kokkos#6161: format fix

* Work around CUDA 11.0 deduction failure for tuple

* Do not use mdspan from compiler by default even if header is detected

* kokkos#6161: make snapshot consistent with mdspan

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
nliber pushed a commit to nliber/kokkos that referenced this pull request Jun 22, 2023
@nmm0 @crtrott @nliber
snapshot mdspan namespace changes (kokkos#6162)
540c695 
* kokkos#6161: update mdspan and fix namespaces. Also import from std namespace if using system mdspan

* kokkos#6161: fix formatting

* kokkos#6161: apply mdspan changes from kokkos/mdspan#271

* kokkos#6161: make namespace qualification consistent

* kokkos#6161: fix last inconsistent namespace qual

* kokkos#6161: fix formatting

* kokkos#6161: use old C++14-compatible traits

* kokkos#6161: copy latest mdspan stable with maybe_static_array bug fix

* kokkos#6161: don't snapshot the stdmode headers as we don't use them and it can cause only conflicts

* kokkos#6161: add -DKokkos_ENABLE_IMPL_MDSPAN=ON config to the generic github ci build, nvhpc, and two cuda ci builds

* kokkos#6161: use feature test macro instead of presence of header to avoid pulling in partial mdspan implementations

* kokkos#6161: use mdspan, layout_*, and default_accessor from std namespace if using compiler-provided mdspan

* kokkos#6161: fix formatting

* kokkos#6161: guard <version> include with c++20 or above

* kokkos#6161: disable standard mdspan if using CUDA or HIP since it may not be compatible

* kokkos#6161: format fix

* Work around CUDA 11.0 deduction failure for tuple

* Do not use mdspan from compiler by default even if header is detected

* kokkos#6161: make snapshot consistent with mdspan

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@crtrott crtrott crtrott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing qualifiers for enable_if_t and is_empty_v
3 participants
@nmm0 @dalg24 @crtrott