Dependency Injection for controllers

kokororin · Nov 29, 2017 · 4a7ff2b · 4a7ff2b
1 parent 666d588
commit 4a7ff2b
Show file tree

Hide file tree

Showing 3 changed files with 76 additions and 4 deletions.
diff --git a/example/app/controllers/Hello.php b/example/app/controllers/Hello.php
@@ -4,7 +4,8 @@
 use app\libraries\Captcha;
 use Kotori\Core\Controller;
 use Kotori\Facade\Cache;
-use Kotori\Facade\Request;
+use Kotori\Facade\Request as FacadeRequest;
+use Kotori\Http\Request;
 
 class Hello extends Controller
 {
@@ -44,9 +45,10 @@ public function addNews()
     /**
      * @route(method = "post", uri = "add")
      */
-    public function insertNews()
+    public function insertNews(Request $request)
     {
-        print_r(Request::post());
+        print_r(FacadeRequest::post());
+        print_r($request->post());
     }
 
     /**

diff --git a/src/Core/Container.php b/src/Core/Container.php
@@ -98,6 +98,27 @@ public static function get($abstract)
         return self::getInstance()->containers[$abstract];
     }
 
+    /**
+     * Get the object instance in the container by class name
+     *
+     * @param  string $className
+     * @return object
+     *
+     * @throws \Kotori\Exception\ContainerException
+     */
+    public static function getByClassName($className)
+    {
+        $bind = self::getInstance()->bind;
+
+        foreach ($bind as $abstract => $abstractClassName) {
+            if ($className == $abstractClassName) {
+                return self::get($abstract);
+            }
+        }
+
+        throw new ContainerException('Cannot find "' . $className . '" in container');
+    }
+
     /**
      * bind object maps for the container
      *

diff --git a/src/Http/Route.php b/src/Http/Route.php
@@ -236,7 +236,14 @@ public function dispatch()
 
         Middleware::register('before_action');
         // Call the requested method
-        call_user_func_array($callback, $this->params);
+
+        $methodInstances = $this->getMethodInstances($callback[0], $callback[1]);
+        if (!$methodInstances) {
+            call_user_func_array($callback, $this->params);
+        } else {
+            call_user_func_array($callback, $methodInstances);
+        }
+
         Middleware::register('after_action');
     }
 
@@ -288,6 +295,48 @@ public function getParams()
         return array_merge($params);
     }
 
+    /**
+     * Returns the request params instances
+     *
+     * @param  string $className
+     * @param  string $methodName
+     * @return mixed
+     *
+     * @throws \Kotori\Exception\NotFoundException
+     */
+    private function getMethodInstances($className, $methodName = '__construct')
+    {
+        $reflectClass = new ReflectionClass($className);
+        $instances = [];
+
+        if ($reflectClass->hasMethod($methodName)) {
+            $reflectMethod = $reflectClass->getMethod($methodName);
+
+            $params = $reflectMethod->getParameters();
+
+            $hasDI = false;
+
+            if (count($params) > 0) {
+                foreach ($params as $param) {
+                    $paramClass = $param->getClass();
+                    if ($paramClass) {
+                        $paramClassName = $paramClass->getName();
+                        array_push($instances, Container::getByClassName($paramClassName));
+                        $hasDI = true;
+                    } elseif ($hasDI) {
+                        throw new NotFoundException('Dependency Injection cannot work with normal params');
+                    }
+                }
+            }
+        }
+
+        if ($hasDI) {
+            return $instances;
+        }
+
+        return false;
+    }
+
     /**
      * Returns the URI
      *