Update uncovered tests

package.json

@@ -37,6 +37,8 @@
   },
   "homepage": "https://github.com/kokororin/honoka#readme",
   "dependencies": {
+    "array-reduce": "^0.0.0",
+    "foreach": "^2.0.5",
     "node-fetch": "^1.7.2",
     "querystring": "^0.2.0",
     "whatwg-fetch": "^2.0.3"

src/defaults.js

@@ -1,5 +1,4 @@
-import { forEach } from './utils';
-
+import forEach from 'foreach';
 // honoka default options
 const defaults = {
   baseURL: '',

src/honoka.js

@@ -1,3 +1,5 @@
+import forEach from 'foreach';
+import reduce from 'array-reduce';
 import qsEncode from 'querystring/encode';
 import {
   trimStart,
@@ -9,9 +11,7 @@ import {
   isArray,
   isString,
   isFormData,
-  isNode,
-  forEach,
-  reduce
+  isNode
 } from './utils';
 import defaults from './defaults';
 import methods from './methods';

src/interceptors.js

@@ -1,4 +1,3 @@
-// honoka interceptors injections
 const interceptorContainer = [];
 
 function register(interceptor) {

src/utils.js

@@ -1,3 +1,4 @@
+import forEach from 'foreach';
 import methods from './methods';
 
 const spaceChars = ' \\s\u00A0';
@@ -16,7 +17,6 @@ export function trimEnd(str, charlist = spaceChars) {
 }
 
 const toString = Object.prototype.toString;
-const hasOwn = Object.prototype.hasOwnProperty;
 
 export function isObject(value) {
   return value !== null && typeof value === 'object';
@@ -35,53 +35,14 @@ export function isFormData(value) {
 }
 
 export function isNode() {
-  return !!(
+  if (
     typeof global.process !== 'undefined' &&
-    global.process.versions &&
-    global.process.versions.node
-  );
-}
-
-export function forEach(object, fn, context) {
-  if (toString.call(fn) !== '[object Function]') {
-    throw new TypeError('iterator must be a function');
-  }
-
-  const l = object.length;
-  if (l === +l) {
-    for (let i = 0; i < l; i++) {
-      fn.call(context, object[i], i, object);
-    }
-  } else {
-    for (const k in object) {
-      if (Object.prototype.hasOwnProperty.call(object, k)) {
-        fn.call(context, object[k], k, object);
-      }
-    }
-  }
-}
-
-export function reduce(array, fn, initialValue) {
-  let hasAcc = arguments.length >= 3;
-  if (hasAcc && array.reduce) {
-    return array.reduce(fn, initialValue);
-  }
-  if (array.reduce) {
-    return array.reduce(fn);
-  }
-
-  for (let i = 0; i < array.length; i++) {
-    if (!hasOwn.call(array, i)) {
-      continue;
-    }
-    if (!hasAcc) {
-      initialValue = array[i];
-      hasAcc = true;
-      continue;
-    }
-    initialValue = fn(initialValue, array[i], i);
+    /* istanbul ignore next */ global.process.versions &&
+    /* istanbul ignore next */ global.process.versions.node
+  ) {
+    /* istanbul ignore next */ return true;
   }
-  return initialValue;
+  return false;
 }
 
 export function isAbsoluteURL(url) {

test/honokaTest.js

@@ -64,6 +64,18 @@ describe('honoka', () => {
     expect(data instanceof ArrayBuffer).to.equal(true);
   });
 
+  it('honoka() should throw Error when dataType is "buffer"', async () => {
+    let err;
+    try {
+      await honoka(`${EXPRESS_BASE_URL}/with/blob`, { dataType: 'buffer' });
+    } catch (e) {
+      err = e;
+    }
+    expect(() => {
+      throw err;
+    }).to.throw(/"buffer" is not supported in browser/);
+  });
+
   it('honoka.post() should post JSON correctly', async () => {
     const data = await honoka.post(`${EXPRESS_BASE_URL}/post/param`, {
       headers: {

webpack.config.js

@@ -69,7 +69,7 @@ if (process.env.NODE_ENV === 'test') {
   config.module.rules.push({
     test: /\.(js|jsx)$/,
     enforce: 'post',
-    exclude: /node_modules|test/,
+    exclude: /node_modules|test|src\/interceptors\.js/,
     loader: 'istanbul-instrumenter-loader',
     options: {
       esModules: true

yarn.lock

@@ -224,6 +224,10 @@ array-includes@^3.0.3:
     define-properties "^1.1.2"
     es-abstract "^1.7.0"
 
+array-reduce@^0.0.0:
+  version "0.0.0"
+  resolved "https://registry.npmjs.org/array-reduce/-/array-reduce-0.0.0.tgz#173899d3ffd1c7d9383e4479525dbe278cab5f2b"
+
 array-slice@^0.2.3:
   version "0.2.3"
   resolved "https://registry.npmjs.org/array-slice/-/array-slice-0.2.3.tgz#dd3cfb80ed7973a75117cdac69b0b99ec86186f5"