Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#87 #65 #68 #108 recursive addChild support #10

Merged

Conversation

kusmierz
Copy link

No description provided.

@kusmierz
Copy link
Author

Would be awesome to use your fork, but I need this fix also. Could you merge it please?

@kokspflanze
Copy link
Owner

@kusmierz i will check it friday/saturday, atm in vacation, hope this is okay=]

@kokspflanze kokspflanze self-assigned this May 26, 2017
@kokspflanze kokspflanze merged commit 20331c3 into kokspflanze:master May 26, 2017
@kokspflanze
Copy link
Owner

@kusmierz i hope you can work, with dev-master, i will work on some more tests for next main version

@kusmierz
Copy link
Author

Great, thanks @kokspflanze!

@kusmierz
Copy link
Author

Hm, unfortunately I have to wait for 1.4.x release, as I'm using zf 2.x...

@kokspflanze
Copy link
Owner

i will see what i can do tomorrow for 1.x release with this kind of fix.

have also to create a test for that.

@kokspflanze
Copy link
Owner

@kusmierz
Copy link
Author

Thanks. Had some problem with FlashMessanger view helper (service alias can't create service), unfortunately it isn't just in-place replacement. Will look at it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants