feat: Verify chart upload in repo when deploying #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cho-William
requested review from
sschnabe,
rpahli,
fabian-schlegel,
wistefan,
axdotl and
nazarovkv
as code owners
Cho-William
commented
Nov 21, 2023
Cho-William
commented
Nov 21, 2023
Cho-William
commented
Nov 21, 2023
Cho-William
commented
Nov 21, 2023
Cho-William
commented
Nov 21, 2023
Cho-William
commented
Nov 21, 2023
Cho-William
commented
Nov 21, 2023
|
I've updated the main in this repo to refactor the binaries storage. This will also solve your build problems. I've create a pr with merging main into your repository. Please see TechnologyBrewery#5 |
sschnabe
requested changes
Nov 30, 2023
Cho-William
force-pushed
the
upload-verification
branch
from
ff12308
to
688af8d
Compare
|
Thank you for implementing that fix for the binaries. I've implemented the requested changes and rebased. |
sschnabe
approved these changes
Dec 11, 2023
|
Sorry for the delay. Released as 6.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue when deploying with the helm-maven-plugin in the following scenario:
This PR adds a uploadVerification flag which will check if the reindexing of a chart is complete by repeatedly running
helm show chart <chartName> --version <chartVersion>until either the chart is verified or if the timeout period is reached (set with uploadVerificationTimeout).