Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pojo with additionalProperties and more than one property genrerate a borken hashCode function with empty parameters #336

Closed
etremblay opened this issue Nov 22, 2023 · 2 comments
Closed

Pojo with additionalProperties and more than one property genrerate a borken hashCode function with empty parameters #336

etremblay opened this issue Nov 22, 2023 · 2 comments
Assignees
@sschnabe
Labels
bug Something isn't working

Comments

@etremblay
Copy link

Affect master, 3.4.8

Expected :

return java.util.Objects.hash(this.additionalProperties, prop1, prop2);

got

return java.util.Objects.hash(this.additionalProperties, , , prop1, prop2);

The modelPojo.mustache template can be fxed by replacing

return java.util.Objects.hash({{#vendorExtensions.additionalPropertiesMap}}this.additionalProperties{{#vars}}, {{/vars}}...

by

return java.util.Objects.hash({{#vendorExtensions.additionalPropertiesMap}}this.additionalProperties{{#vars.size}}, {{/vars.size}}...
@etremblay
Copy link
Author

Probably caused by #315

@sschnabe sschnabe self-assigned this Dec 24, 2023
@sschnabe sschnabe added the bug Something isn't working label Dec 24, 2023
sschnabe added a commit that referenced this issue Dec 24, 2023
@sschnabe
Add test case for #336
092fb9f
sschnabe added a commit that referenced this issue Dec 24, 2023
@sschnabe
Fix hashCode for additionalProperties, rel #336
f021e0a
sschnabe added a commit that referenced this issue Dec 24, 2023
@sschnabe
Fix hashCode for additionalProperties, fix #336
da94254
@sschnabe
Copy link
Member

@etremblay Thx for your report. PR is created.

sschnabe added a commit that referenced this issue Dec 24, 2023
@sschnabe
Add test case for #336
d331480
sschnabe added a commit that referenced this issue Dec 24, 2023
@sschnabe
Fix hashCode for additionalProperties, fix #336
9c18110
sschnabe added a commit that referenced this issue Dec 24, 2023
@sschnabe
Add test case for #336
6e67b3f
sschnabe added a commit that referenced this issue Dec 24, 2023
@sschnabe
Fix hashCode for additionalProperties, fix #336
6e6a942
sschnabe added a commit that referenced this issue Dec 24, 2023
@sschnabe
Add test case for #336
7c504b8
sschnabe added a commit that referenced this issue Dec 24, 2023
@sschnabe
Fix hashCode for additionalProperties, fix #336
f830de3
sschnabe added a commit that referenced this issue Dec 24, 2023
@sschnabe
Add test case for #336
a071430
sschnabe added a commit that referenced this issue Dec 24, 2023
@sschnabe
Fix hashCode for additionalProperties, fix #336
3b0467c
sschnabe added a commit that referenced this issue Dec 24, 2023
@sschnabe
Add test case for #336
09e4c10
sschnabe added a commit that referenced this issue Dec 24, 2023
@sschnabe
Fix hashCode for additionalProperties, fix #336
310e1c0
sschnabe added a commit that referenced this issue Dec 25, 2023
@sschnabe
Add test case for #336
fef889b
sschnabe added a commit that referenced this issue Dec 25, 2023
@sschnabe
Fix hashCode for additionalProperties, fix #336
e29d383
sschnabe added a commit that referenced this issue Dec 25, 2023
@sschnabe
Fix hashCode for additionalProperties, fix #336 (#346)
35f2d08 
* Add test case for #336

* Fix hashCode for `additionalProperties`, fix #336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sschnabe sschnabe

Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@etremblay @sschnabe