Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validations for Optional is misplaced #372

Closed
sschnabe opened this issue Feb 23, 2024 · 0 comments · Fixed by #373
Closed

Validations for Optional is misplaced #372

sschnabe opened this issue Feb 23, 2024 · 0 comments · Fixed by #373
Assignees
@sschnabe
Labels
bug Something isn't working

Comments

@sschnabe
Copy link
Member 

@Valid Optional<Model> model

should be

Optional<@Valid Model> model
@sschnabe sschnabe added the bug Something isn't working label Feb 23, 2024
@sschnabe sschnabe self-assigned this Feb 23, 2024
@sschnabe sschnabe linked a pull request Feb 23, 2024 that will close this issue
Move validations from Optional into Optional generics, fix #372 #373
Merged
sschnabe added a commit that referenced this issue Feb 23, 2024
@sschnabe
Move validations from Optional into Optional generics, fix #372 (#373)
2776b0a 
* Add testcase for apis with optional and validation

* Add Optional in Codegen and not in mustache

* Move validations from optional into optional generics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sschnabe sschnabe

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move validations from Optional into Optional generics, fix #372 kokuwaio/micronaut-openapi-codegen
1 participant
@sschnabe