Identify reply by host, indentifier and sequence number #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For extra type safety when shuffling around these u16 values.
Instead of passing a randomized unique value as payload to identify a specific reply use the host, identity and sequence number. This allows us to send a payload of 0-N bytes instead of 16-N. Also changed Pinger::ping() to take a u8 slice for payload.
|
@oll3 Thanks a lot for your PR~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kolapapa,
I wanted to modify the library to allow it to send a payload smaller than 16 bytes. To achieve this I replaced the lookup of replies using the uuid/random identifier carried in payload by using the pinged host+ping identifier+sequence number. So for each sent request we expect a reply with the same parameters. This change also means that two pingers pinging the same host with the same ident and same sequence number at the same time can not be allowed. Trying to do this now will result in an error.
However my initial, seemingly small change ended up being quite big. And I realize this might not suite this library and your case so I very much understand if you won't accept this PR. Still wanted to give you a chance to have a look and see if it can be to any use.
Thanks again for sharing this library!